Updown label types - value reverts back to original

If you have a question about the software please ask it here.

Updown label types - value reverts back to original

Postby beefy » Thu Dec 01, 2016 10:14 am

Hi Balazs,

I’ve just noticed something interesting about an UPDOWN type DRO. I created an additional THC FEEDRATE DRO (label No 224) and made it an UPDOWN type.

If the DRO was previously at 900 and I used the updown arrows to increase the value to 920, if I click “Apply Settings” the value went back to 900. However if I type the value 920 into the DRO and click Apply Settings the value stays at 920.

Does an UPDOWN type DRO not work for UCcnc system labels. Is it only for custom user labels ??

Thanks,

Keith.
beefy
 
Posts: 449
Joined: Mon Sep 05, 2016 10:34 am

Re: Updown label types - value reverts back to original

Postby cncdrive » Thu Dec 01, 2016 3:03 pm

I've quickly tested this, but it works fine here.
I've changed the THC feedrate DRO to updown type and if I change the value with the arrow keys (increase or decrease) and apply settings then the DRO keeps the new value,
also if I type in new value and allpy settings the DRO keeps the new value.
cncdrive
Site Admin
 
Posts: 4887
Joined: Tue Aug 12, 2014 11:17 pm

Re: Updown label types - value reverts back to original

Postby beefy » Thu Dec 01, 2016 8:56 pm

I did more tests.

If I do exactly what you did and change the "ORIGINAL" DRO on the I/O SETUP tab layer (layernumber 8) I get the same results as you, it works fine.

However, if I copy that DRO and place a 2nd or 3rd one on the same layer or on another layer, and I use the UP/DOWN arrows to change the value, when I press Apply Settings the value goes back to what it originally was.

It's as though the original DRO is "the master" and any copies are slaves, and only the master can change values via the UP/DOWN arrows.

Keith
beefy
 
Posts: 449
Joined: Mon Sep 05, 2016 10:34 am

Re: Updown label types - value reverts back to original

Postby cncdrive » Thu Dec 01, 2016 11:26 pm

Hi Keith,

Ahh, ok, that information was missing, that you placed more than one instances of the same DRO.
I've checked it and the issue is that the up/down arrow key presses do not seem to copy the value to the same number of DROs like when you validate a new value to the DRO with text input, that code goes through the fields array and change all DROs which have the same IDs.
I will try to change some code in the arrows press event to copy the value just like with the text input...
cncdrive
Site Admin
 
Posts: 4887
Joined: Tue Aug 12, 2014 11:17 pm

Re: Updown label types - value reverts back to original

Postby beefy » Fri Dec 02, 2016 12:21 am

Wonderful Balazs,

I did actually say in my first post "I created an additional THC FEEDRATE DRO (label No 224) and made it an UPDOWN type", but I should have been a lot clearer. Sorry about that. It also never even occurred to me to check the original DRO.

Now I'd like to understand a little better HOW the UP/DOWN incrementing/decrementing of an updown DRO works.

Some time ago I emailed you about having the ability to change the value in "non critical system DROs" (like THC Feedrate), so that the value could be changed WHILE gcode is running. You said you and your partner would look into this and allow certain DROs to have this ability.

I've noticed I can now change values in certain DROs while gcode is running but I think the "Apply Settings" button doesn't work while gcode is running. So if I use the up/down arrows on an updown DRO the values changes but is it actually "read" by UCcnc ???

For example if I increment an updown THC FEEDRATE dro using the up arrow, WHILE gcode is running, will the THC feedrate increase.

Keith
beefy
 
Posts: 449
Joined: Mon Sep 05, 2016 10:34 am

Re: Updown label types - value reverts back to original

Postby cncdrive » Fri Dec 02, 2016 1:54 pm

Hi Keith,

Yep, after we (You, Terry and me) discussed about that some textfield are better to remain accessible when g-code is running,
I told you that we will looking into it and will implement it as soon as possible.
If I recall shorly after that you got busy with some work, but we kept going on implementing this idea and collected the DROs of interest for this feature and implemented to them.

So, the FRO, SRO, and the THC DROs are all accessible even when g-code is running, and fields with IDs >= 20000 are also.

And yes, if you change the THC feedrate while g-code is running then it will change the value and the THC feedrate will change on the fly. :)

I'm not sure about the Arrow keys now, because as turned out in your previous observation post it seems the arrows are not perfect yet,
but will check them soon, because they should also change the value just like new value/text typing.
cncdrive
Site Admin
 
Posts: 4887
Joined: Tue Aug 12, 2014 11:17 pm

Re: Updown label types - value reverts back to original

Postby beefy » Fri Dec 02, 2016 8:25 pm

Thanks very much Balazs, great support as usual.

And yes, that's correct I did get busy with work. I tend to think of it as the need for financial survival causing imprisonment in my business. It was (is) very frustrating being pulled away from playing with UCcnc, learning coding, electronics, etc. I was progressing slowly but steadily before.

Keith.
beefy
 
Posts: 449
Joined: Mon Sep 05, 2016 10:34 am


Return to Ask a question from support here

Who is online

Users browsing this forum: No registered users and 44 guests